reswqa commented on code in PR #22415:
URL: https://github.com/apache/flink/pull/22415#discussion_r1210172229
##########
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarHandlerParameterTest.java:
##########
@@ -85,7 +85,7 @@ enum ProgramArgsParType {
static Time timeout = Time.seconds(10);
static Map<String, String> responseHeaders = Collections.emptyMap();
- private static Path jarWithManifest;
+ static Path jarWithManifest;
Review Comment:
I don't think this is necessary, we can use `jarWithEagerSink` in
`testConfigurationWithEmptySavepointPath` instead of this.
##########
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java:
##########
@@ -202,6 +202,20 @@ JarRunRequestBody getJarRequestBody(ProgramArgsParType
programArgsParType) {
FLINK_CONFIGURATION.toMap());
}
+ JarRunRequestBody getJarRequestBodyWithSavepointPath(
Review Comment:
This method can be private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
