echauchot commented on PR #22667: URL: https://github.com/apache/flink/pull/22667#issuecomment-1568586002
> I'd start a separate discussion on these. we likely want to make Preconditions/VisibleForTesting public. Not sure about `DataInput*`, maybe we can look at how it would look like in Cassandra and then make a call. ClosureCleaner I'm also not sure about, but we could consider handling this internally in Flink instead of having each connector use it (e.g., call it in StreamExEnv#addSource) Yes I was about to open a dedicated Cassandra ticket for `DataInput*` / `DataOutput*` removal. I could open a PR to replace them with JDK counterparts and discuss there if it is better for Cassandra connector to use JDK libs instead of non-public flink lib. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
