echauchot commented on PR #22667: URL: https://github.com/apache/flink/pull/22667#issuecomment-1584508623
> Since each of these modifies the rules I'd assume each of these individually would also have to update the store. So it's either that or squash them all together. (again, key rule is that each merged commit should individually pass on CI; if they'd already pass go ahead) > > ``` > [FLINK-31806] Fix public API rule for connectors > [FLINK-31806] Add a rule to test non-public enclosing classes > [FLINK-31806] Reverse rule to positive asumption and update violation… > ``` Makes total sense. As the first rule was missing the enclosed class case, the second rule was missing a sub-case, there is no point in keeping these commits, I'll squash them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
