mohsenrezaeithe commented on code in PR #21849:
URL: https://github.com/apache/flink/pull/21849#discussion_r1210611788


##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java:
##########
@@ -232,6 +233,27 @@ public void 
testDuplicateJobSubmissionWithGloballyTerminatedAndCleanedJob() thro
         assertDuplicateJobSubmission();
     }
 
+    @Test
+    public void testDuplicateJobSubmissionIsDetected() throws Exception {

Review Comment:
   I didn't find a test that focused on this part of the code, and this was 
meant to optimistically reproduce what's being fixed (running the test locally 
reproduced the issue just fine).
   
   @zentol do you have any suggestions on how to improve this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to