mohsenrezaeithe commented on code in PR #21849:
URL: https://github.com/apache/flink/pull/21849#discussion_r1210860396
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -1513,13 +1517,20 @@ private CompletableFuture<Void> waitForTerminatingJob(
throwable));
});
- return jobManagerTerminationFuture.thenAcceptAsync(
+ // keep track of the job as outstanding, if not done
+ if (!jobManagerTerminationFuture.isDone()) {
+ submittedAndWaitingTerminationJobIDs.add(jobId);
+ }
Review Comment:
Moved to the `internalSubmitJob` to always add before returning with a
`waitForTerminatingJob` future for removing a possible race. It's now removed
in `handleTermination`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
