[
https://issues.apache.org/jira/browse/FLINK-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605221#comment-15605221
]
ASF GitHub Bot commented on FLINK-4894:
---------------------------------------
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2690
[FLINK-4894] [network] Don't request buffer after writing to partition
After emitting a record via the RecordWriter, we eagerly requested a new
buffer for the next emit on that channel (although it's not clear that we will
immediately need it). With this change, we request that buffer lazily when an
emit call requires it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 4894-late_request_buffer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2690
----
commit a4dbe0c8db4bd8fee1a508ae212f80fa7c8bb824
Author: Ufuk Celebi <[email protected]>
Date: 2016-10-24T16:01:28Z
[FLINK-4894] [network] Don't request buffer after writing to partition
After emitting a record via the RecordWriter, we eagerly requested
a new buffer for the next emit on that channel (although it's not clear
that we will immediately need it). With this change, we request that
buffer lazily when an emit call requires it.
----
> Don't block on buffer request after broadcastEvent
> ---------------------------------------------------
>
> Key: FLINK-4894
> URL: https://issues.apache.org/jira/browse/FLINK-4894
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> After broadcasting an event (like the checkpoint barrier), the record writer
> might block on a buffer request although that buffer will only be needed on
> the next write on that channel.
> Instead of assuming that each serializer has a buffer set, we can change the
> logic in the writer to request the buffer when it requires one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
