[
https://issues.apache.org/jira/browse/FLINK-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609415#comment-15609415
]
ASF GitHub Bot commented on FLINK-4894:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2690
This looks very good.
To double check: Do we have tests for the following situations?
- Records larger than buffers
- Records such that they exactly line up with buffer size (full record
and full buffer always coincide)
If not, those would be important to have.
Otherwise +1 to merge this to for both 1.2.0 and 1.1.4
> Don't block on buffer request after broadcastEvent
> ---------------------------------------------------
>
> Key: FLINK-4894
> URL: https://issues.apache.org/jira/browse/FLINK-4894
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> After broadcasting an event (like the checkpoint barrier), the record writer
> might block on a buffer request although that buffer will only be needed on
> the next write on that channel.
> Instead of assuming that each serializer has a buffer set, we can change the
> logic in the writer to request the buffer when it requires one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
