echauchot commented on PR #17: URL: https://github.com/apache/flink-connector-cassandra/pull/17#issuecomment-1578914220
> new ByteArrayOutputStream(); But that is the same code I pushed except you've put the ByteArrayOutputStream creation outside of the try-with-resources and the return outside of the try block ? This is more of a coding style matter. The other connectors I've looked at (kafka and pulsar) and the other serializer in cassandra connector all use the coding style I used, so for consistency I would tend to keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
