echauchot commented on PR #17: URL: https://github.com/apache/flink-connector-cassandra/pull/17#issuecomment-1582359194
> > > But that is the same code I pushed except > > > > > > Main thing is avoiding the explicit flush call shrug > > Ah, I missed it ! Yeah, better, having the try-with-resources closing before the return statement allows automatically calling ObjectOutputStream#close() that does the flush. Thanks for the suggestion, I'll update the other Cassandra serializer as well. Done, merging as soon as I have the tests passing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
