wanglijie95 commented on PR #22686:
URL: https://github.com/apache/flink/pull/22686#issuecomment-1582077192

   Thanks @huwh for creating this PR. I have a different idea:
   
   We can create the `TaskDeploymentDescriptorFactory` outside ExecutionGraph 
and pass it in through the ctor. The`TaskDeploymentDescriptorFactory` provides 
a `createDeploymentDescriptor(Execution execution, ...)` method to create the 
deployment descriptor for an execution. 
   
   In this way, the job/graph level configurations such as 
`partitionLocationConstraint` and `nonFinishedHybridPartitionShouldBeUnknown` 
should be passed into the `TaskDeploymentDescriptorFactory` instead of 
`ExecutionGraph`.
   
   WDYT ? @Thesharing @reswqa 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to