ruanhang1993 commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1222615155
########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/enumerate/NonSplittingRegexEnumerator.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.src.enumerate; + +import org.apache.flink.connector.file.src.FileSourceSplit; +import org.apache.flink.core.fs.FileStatus; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collection; +import java.util.function.Predicate; + +/** + * This {@code FileEnumerator} enumerates all files under the given paths recursively. Each file + * matched the given regex pattern becomes one split; this enumerator does not split files into + * smaller "block" units. + * + * <p>This enumerator filters out files with the common hidden file prefixes '.' and '_'. + */ +public class NonSplittingRegexEnumerator extends NonSplittingRecursiveEnumerator { + + private final Predicate<Path> fileFilter; + private final RegexFileFilter regexFileFilter; + + public NonSplittingRegexEnumerator(String pathPattern) { + this(pathPattern, new DefaultFileFilter()); + } + + public NonSplittingRegexEnumerator(String pathPattern, Predicate<Path> fileFilter) { + this.regexFileFilter = new RegexFileFilter(pathPattern); + this.fileFilter = fileFilter; + } + + @Override + public Collection<FileSourceSplit> enumerateSplits(Path[] paths, int minDesiredSplits) + throws IOException { + final ArrayList<FileSourceSplit> splits = new ArrayList<>(); + for (Path path : paths) { + final FileSystem fs = path.getFileSystem(); + final FileStatus status = fs.getFileStatus(path); + addSplitsForPath(status, fs, splits, regexFileFilter); Review Comment: The method `addSplitsForPath ` will be invoked in itself at line 83. The last parameter may be null. When it is null, we will know the dir/file comes from a matched path. And we will handle them if they are not filtered by the custom `fileFilter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
