ruanhang1993 commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1236234583
########## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/enumerate/BlockSplittingRecursiveAllDirEnumerator.java: ########## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.src.enumerate; + +import org.apache.flink.connector.file.src.FileSourceSplit; +import org.apache.flink.connector.file.src.compression.StandardDeCompressors; +import org.apache.flink.core.fs.BlockLocation; +import org.apache.flink.core.fs.FileStatus; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Nullable; + +import java.io.IOException; +import java.util.Arrays; +import java.util.List; +import java.util.function.Predicate; + +/** + * This {@code FileEnumerator} enumerates all files under the given paths recursively except the + * hidden directories, and creates a separate split for each file block. + * + * <p>Please note that file blocks are only exposed by some file systems, such as HDFS. File systems + * that do not expose block information will not create multiple file splits per file, but keep the + * files as one source split. + * + * <p>Files with suffixes corresponding to known compression formats (for example '.gzip', '.bz2', + * ...) will not be split. See {@link StandardDeCompressors} for a list of known formats and + * suffixes. + * + * <p>Compared to {@link BlockSplittingRecursiveEnumerator}, this enumerator will enumerate all + * files even through its parent directory is filtered out by the file filter. + */ +public class BlockSplittingRecursiveAllDirEnumerator extends NonSplittingRecursiveAllDirEnumerator { Review Comment: `BlockSplittingRecursiveAllDirEnumerator` need to reuse the method `addSplitsForPath` in `NonSplittingRecursiveAllDirEnumerator`, not `BlockSplittingRecursiveEnumerator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
