huwh commented on PR #22686: URL: https://github.com/apache/flink/pull/22686#issuecomment-1582514069
Thanks @wanglijie95 and @Thesharing for the analysis. After making a quick code changes, I think it makes sense to change TaskDeploymentDescriptorFactory to Job Level, so it only contains job level immutable configurations. We create the TaskDeploymentDescriptorFactory in the DefaultExecutionGraphBuilder and pass it to the ExecutionGraph. Executions can use TaskDeploymentDescriptorFactory#createDeploymentDescriptor(Execution execution, ...) to create the DeploymentDescriptor, and in this method, we can put all execution-level configurations, such as InputGateDeploymentDescriptors, into the DeploymentDescriptor. I will take more tests to confirm this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
