pvary commented on code in PR #615:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/615#discussion_r1223968079
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java:
##########
@@ -101,6 +101,11 @@ public boolean scale(FlinkResourceContext<? extends
AbstractFlinkResource<?, ?>>
metricsCollector.updateMetrics(
resource, autoScalerInfo, ctx.getFlinkService(),
conf);
+ if (collectedMetrics.getMetricHistory().isEmpty()) {
+ autoScalerInfo.replaceInKubernetes(kubernetesClient);
Review Comment:
nit: Does it worth to add a comment here as well, like:
```
// We have metrics yet, but we are not ready for scaling.
```
Do I understand correctly the intent of the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
