gyfora commented on code in PR #615:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/615#discussion_r1224035631
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java:
##########
@@ -101,6 +101,11 @@ public boolean scale(FlinkResourceContext<? extends
AbstractFlinkResource<?, ?>>
metricsCollector.updateMetrics(
resource, autoScalerInfo, ctx.getFlinkService(),
conf);
+ if (collectedMetrics.getMetricHistory().isEmpty()) {
+ autoScalerInfo.replaceInKubernetes(kubernetesClient);
Review Comment:
At this point we have no metrics, so there is nothing to do. What you
commented actually happens a bit down in the code and has a similar comment :)
This piece of code was deleted in a previous commit I just restored it and
added a test to make sure we dont accidentally remove/break it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
