gyfora commented on code in PR #616:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/616#discussion_r1223977914
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java:
##########
@@ -184,7 +184,13 @@ protected JobTopology
queryJobTopology(RestClusterClient<String> restClient, Job
JobDetailsInfo.JobVertexDetailsInfo
::getMaxParallelism));
- return JobTopology.fromJsonPlan(jobDetailsInfo.getJsonPlan(),
maxParallelismMap);
+ // Flink 1.17 introduced a strange behaviour where the
JobDetailsInfo#getJsonPlan()
+ // doesn't return the jsonPlan correctly but it wraps with
RawJson{json='plan'}
+ var rawPlan = jobDetailsInfo.getJsonPlan();
+ var json =
Review Comment:
This logic is fixed based on the Flink client library (1.17.1). This issue
will be fixed in 1.17.2 then we can remove this workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
