pvary commented on code in PR #616:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/616#discussion_r1223978298
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java:
##########
@@ -184,7 +184,13 @@ protected JobTopology
queryJobTopology(RestClusterClient<String> restClient, Job
JobDetailsInfo.JobVertexDetailsInfo
::getMaxParallelism));
- return JobTopology.fromJsonPlan(jobDetailsInfo.getJsonPlan(),
maxParallelismMap);
+ // Flink 1.17 introduced a strange behaviour where the
JobDetailsInfo#getJsonPlan()
+ // doesn't return the jsonPlan correctly but it wraps with
RawJson{json='plan'}
+ var rawPlan = jobDetailsInfo.getJsonPlan();
+ var json =
Review Comment:
Discussed it with @gyfora:
- The issue is with the client library we include, and it is tied to the
operator
- The issue will be fixed in Flink 1.17.2. The test will break on upgrade
and we can fix/remove this change at that time
For a temporary fix, this should be ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
