XComp commented on code in PR #22601:
URL: https://github.com/apache/flink/pull/22601#discussion_r1229545380
##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java:
##########
@@ -247,7 +247,7 @@ private LeaderElection createLeaderElection(String
leaderName) throws Exception
leaderElectionService.startLeaderElectionBackend();
closeableRegistry.registerCloseable(leaderElectionService);
- return leaderElectionService.createLeaderElection();
+ return leaderElectionService.createLeaderElection(leaderName);
Review Comment:
phew, you got me on that one. :-D I was confused for a second as well. It's
indeed a bit confusing right now. The `contenderID` isn't passed forward to the
`LeaderElectionDriver` within the `DefaultLeaderElectionService` right now. It
becomes used as soon as we're switching from the `LeaderElectionDriver`
interface to `MultipleComponentLeaderElectionDriver` within
`DefaultLeaderElectionService`. That's going to happen in PR #22661
I'm going to add comments to explain this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
