XComp commented on code in PR #22601:
URL: https://github.com/apache/flink/pull/22601#discussion_r1230500087
##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java:
##########
@@ -247,7 +247,7 @@ private LeaderElection createLeaderElection(String
leaderName) throws Exception
leaderElectionService.startLeaderElectionBackend();
closeableRegistry.registerCloseable(leaderElectionService);
- return leaderElectionService.createLeaderElection();
+ return leaderElectionService.createLeaderElection(leaderName);
Review Comment:
The `contenderID` that's passed in through `createLeaderElection` is saved
in the `DefaultLeaderElection` and forwarded in each call to the
`DefaultLeaderElectionService`. But we don't forward it for now to the driver.
The driver gets it through the `MultipleComponentLeaderElectionDriverAdapter`
for now (which gets the value through
[AbstractHaServices:246](https://github.com/XComp/flink/blob/f4c8cdb8f370de26f55759e7ea4b6f5461c7a806/flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java#L246)).
In FLINK-31783 (PR #22661), we will remove the adapter functionality and
integrate the `MultipleComponentLeaderElectionDriver` into
`DefaultLeaderElectionService`. I replaced the variable usage with a static
string that should make it clearer that the value isn't used for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
