gyfora commented on code in PR #614:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/614#discussion_r1230993569
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/TestingFlinkDeploymentController.java:
##########
@@ -112,13 +119,33 @@ public TestingFlinkDeploymentController(
public UpdateControl<FlinkDeployment> reconcile(
FlinkDeployment flinkDeployment, Context<FlinkDeployment> context)
throws Exception {
FlinkDeployment cloned = ReconciliationUtils.clone(flinkDeployment);
+ updateGeneration(cloned);
statusUpdateCounter.setCurrent(flinkDeployment);
UpdateControl<FlinkDeployment> updateControl =
flinkDeploymentController.reconcile(cloned, context);
Assertions.assertTrue(updateControl.isNoUpdate());
return updateControl;
}
+ private void updateGeneration(FlinkDeployment resource) {
Review Comment:
It's copy paste as the testing controllers do not share a superclass. This
could be refactored and improved in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
