gyfora commented on code in PR #614:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/614#discussion_r1235447279
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java:
##########
@@ -165,30 +159,6 @@ private static String scalingReport(
return sb.toString();
}
- private boolean stabilizationPeriodPassed(
- AbstractFlinkResource<?, ?> resource, Configuration conf) {
- var jobStatus = resource.getStatus().getJobStatus();
-
- if (!JobStatus.RUNNING.name().equals(jobStatus.getState())) {
- // Never consider a non-running job stable
- return false;
- }
-
- var startTs =
- Instant.ofEpochMilli(
- // Use the update time which will reflect the latest
job state update
- // Do not use the start time because it doesn't tell
when the job went to
- // RUNNING
- Long.parseLong(jobStatus.getUpdateTime()));
- var stableTime = startTs.plus(conf.get(STABILIZATION_INTERVAL));
Review Comment:
You moved this logic to the metric collection phase and we do not
evaluate/collect metrics during stabilisation period currently so this code is
unused now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
