[ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733451#comment-17733451 ]
Cai Liuyang commented on FLINK-32362: ------------------------------------- [~fanrui] I compare the two ways, in common case if one task is unready, other subtask may be also unready with high probability, the inner-catch will print many useless log(with the same reason), so i chose the outer-catch > SourceAlignment announceCombinedWatermark period task maybe lost > ---------------------------------------------------------------- > > Key: FLINK-32362 > URL: https://issues.apache.org/jira/browse/FLINK-32362 > Project: Flink > Issue Type: Bug > Affects Versions: 1.16.0 > Reporter: Cai Liuyang > Assignee: Cai Liuyang > Priority: Major > Labels: pull-request-available > > When we use sourcealignment,we also found there is another problem that > announceCombinedWatermark may throw a exception (like "subtask 25 is not > ready yet to receive events" , this subtask maybe under failover), which will > lead the period task not running any more (ThreadPoolExecutor will not > schedule the period task if it throw a exception) > I think we should increase the robustness of announceCombinedWatermark > function to avoid it throw any exception (if send fail, just wait next send) > (code see > [https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java#L199] > ) -- This message was sent by Atlassian Jira (v8.20.10#820010)