snuyanzin commented on code in PR #22558:
URL: https://github.com/apache/flink/pull/22558#discussion_r1233372251
##########
flink-table/flink-sql-jdbc-driver/pom.xml:
##########
@@ -84,6 +84,12 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>provided</scope>
+ </dependency>
Review Comment:
yes, sort of.
After closer look I realized that before 1.31.0 `FlinkSqlParserImpl` didn't
depend on guava. And with 1.31.0 after these 2 commits
https://github.com/apache/calcite/commit/7c1e2746b94a50f0bb08571287acb5327fdc1b16
https://github.com/apache/calcite/commit/75d064f659a038371d84f9fdba7847e1631d1f1d
it starts depending on guava and as a result starts requiring same
dependency as for tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
