snuyanzin commented on code in PR #22558:
URL: https://github.com/apache/flink/pull/22558#discussion_r1242916945
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java:
##########
@@ -1132,22 +1132,14 @@ private static List<TestSetSpec> numericBounds() {
.fromCase(DOUBLE(), -1.7976931348623157E308d,
Float.NEGATIVE_INFINITY)
.build(),
CastTestSpecBuilder.testCastTo(DECIMAL(38, 0))
- .fromCase(TINYINT(), Byte.MIN_VALUE - 1, new
BigDecimal(Byte.MIN_VALUE - 1))
- .fromCase(TINYINT(), Byte.MAX_VALUE + 1, new
BigDecimal(Byte.MAX_VALUE + 1))
- .fromCase(
- SMALLINT(),
- Short.MIN_VALUE - 1,
- new BigDecimal(Short.MIN_VALUE - 1))
- .fromCase(
- SMALLINT(),
- Short.MAX_VALUE + 1,
- new BigDecimal(Short.MAX_VALUE + 1))
- .fromCase(
- INT(), Integer.MIN_VALUE - 1, new
BigDecimal(Integer.MIN_VALUE - 1))
- .fromCase(
- INT(), Integer.MAX_VALUE + 1, new
BigDecimal(Integer.MAX_VALUE + 1))
- .fromCase(BIGINT(), Long.MIN_VALUE - 1, new
BigDecimal(Long.MIN_VALUE - 1))
- .fromCase(BIGINT(), Long.MAX_VALUE + 1, new
BigDecimal(Long.MAX_VALUE + 1))
+ .fromCase(TINYINT(), Byte.MIN_VALUE - 1, new
BigDecimal(Byte.MAX_VALUE))
Review Comment:
May be I didn't get what you mean... I added cast for input however here
expected type is `BigDecimal` since here it is cast to `DECIMAL(38, 0)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
