TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233853583
########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/file/PartitionFileIndexImpl.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage.file; + +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.netty.NettyConnectionId; + +import javax.annotation.concurrent.GuardedBy; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Optional; + +import static org.apache.flink.util.Preconditions.checkArgument; + +/** The default implementation of {@link PartitionFileIndex}. */ +public class PartitionFileIndexImpl implements PartitionFileIndex { + + /** + * The regions belonging to each subpartitions. + * + * <p>Note that the field can be accessed by the writing and reading IO thread, so the lock is + * to ensure the thread safety. + */ + @GuardedBy("lock") + private final List<List<Region>> subpartitionRegions; + + /** + * The region index of a reader is reading for each subpartition. The list index is + * corresponding to the subpartition id. The key in the map represents the reader, the value in + * the map represents the reading region index. + */ + @GuardedBy("lock") + private final List<Map<NettyConnectionId, Integer>> subpartitionReaderRegionIndexes; + + @GuardedBy("lock") + private boolean isReleased; + + private final Object lock = new Object(); + + public PartitionFileIndexImpl(int numSubpartitions) { + this.subpartitionRegions = new ArrayList<>(); + this.subpartitionReaderRegionIndexes = new ArrayList<>(); + for (int subpartitionId = 0; subpartitionId < numSubpartitions; ++subpartitionId) { + subpartitionRegions.add(new ArrayList<>()); + subpartitionReaderRegionIndexes.add(new HashMap<>()); + } + } + + @Override + public Optional<Region> getNextRegion( + int subpartitionId, NettyConnectionId nettyServiceWriterId) { + synchronized (lock) { + if (isReleased) { + return Optional.empty(); + } + + int currentRegionIndex = + subpartitionReaderRegionIndexes + .get(subpartitionId) + .getOrDefault(nettyServiceWriterId, 0); + List<Region> currentRegions = subpartitionRegions.get(subpartitionId); + if (currentRegionIndex < currentRegions.size()) { + Region region = currentRegions.get(currentRegionIndex); + ++currentRegionIndex; + subpartitionReaderRegionIndexes + .get(subpartitionId) + .put(nettyServiceWriterId, currentRegionIndex); + return Optional.of(region); + } + return Optional.empty(); + } + } + + @Override + public void addRegionForBuffers(List<SpilledBuffer> spilledBuffers) { + if (spilledBuffers.isEmpty()) { + return; + } + + Map<Integer, List<Region>> convertedRegions = convertToRegions(spilledBuffers); + synchronized (lock) { + convertedRegions.forEach( + (subpartition, regions) -> + subpartitionRegions.get(subpartition).addAll(regions)); + } + } + + @Override + public void release() { + synchronized (lock) { + subpartitionRegions.clear(); + subpartitionReaderRegionIndexes.clear(); + isReleased = true; + } + } + + // ------------------------------------------------------------------------ + // Internal Methods + // ------------------------------------------------------------------------ + + private static Map<Integer, List<Region>> convertToRegions(List<SpilledBuffer> spilledBuffers) { + Map<Integer, List<Region>> subpartitionRegionMap = new HashMap<>(); + Iterator<SpilledBuffer> iterator = spilledBuffers.iterator(); + SpilledBuffer firstBufferInRegion = iterator.next(); + SpilledBuffer lastBufferInRegion = firstBufferInRegion; + + while (iterator.hasNext()) { + SpilledBuffer currentBuffer = iterator.next(); + if (currentBuffer.getSubpartitionId() != firstBufferInRegion.getSubpartitionId() + || currentBuffer.getBufferIndex() != lastBufferInRegion.getBufferIndex() + 1) { + // the current buffer belongs to a new region, close the previous region + addInternalRegionToMap( + firstBufferInRegion, lastBufferInRegion, subpartitionRegionMap); Review Comment: Added the detailed doc for the method `generateRegionsBasedOnBuffers`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
