TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233858138
########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/SubpartitionDiskCacheManager.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.hybrid.tiered.tier.disk; + +import org.apache.flink.core.memory.MemorySegment; +import org.apache.flink.core.memory.MemorySegmentFactory; +import org.apache.flink.runtime.io.network.buffer.Buffer; +import org.apache.flink.runtime.io.network.buffer.Buffer.DataType; +import org.apache.flink.runtime.io.network.buffer.FreeingBufferRecycler; +import org.apache.flink.runtime.io.network.buffer.NetworkBuffer; +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.netty.NettyPayload; + +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.Deque; +import java.util.LinkedList; +import java.util.List; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkState; + +/** + * The {@link SubpartitionDiskCacheManager} is responsible to manage the cached buffers in a single + * subpartition. + */ +public class SubpartitionDiskCacheManager { + + private final int subpartitionId; + + private int finishedBufferIndex; + + // Note that this field can be accessed by the task thread or the write IO thread, so the thread + // safety should be ensured. + private final Deque<NettyPayload> allBuffers = new LinkedList<>(); + + public SubpartitionDiskCacheManager(int subpartitionId) { + this.subpartitionId = subpartitionId; + } + + // ------------------------------------------------------------------------ + // Called by DiskCacheManager + // ------------------------------------------------------------------------ + void appendEndOfSegmentEvent(ByteBuffer record, DataType dataType) { + writeEvent(record, dataType); + } + + int getFinishedBufferIndex() { + return finishedBufferIndex; + } + + void append(Buffer buffer) { + NettyPayload toAddBuffer = + NettyPayload.newBuffer(buffer, finishedBufferIndex, subpartitionId); + addFinishedBuffer(toAddBuffer); + } + + // Note that allBuffers can be touched by multiple threads. + List<NettyPayload> getAllBuffers() { + synchronized (allBuffers) { + List<NettyPayload> targetBuffers = new ArrayList<>(allBuffers); + allBuffers.clear(); Review Comment: Fixed by renaming it to `removeAllBuffers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
