snuyanzin commented on PR #22624: URL: https://github.com/apache/flink/pull/22624#issuecomment-1596941999
hi @zhougit86 it looks ok from my side thanks for addressing comments the only nit pick: could you please rename `CastFunctionMiscITLegacyCase` in way that it matches regex `'[A-Z][A-Za-z\d]*Test(s|Case)?|Test[A-Z][A-Za-z\d]*|IT(.*)|(.*)IT(Case)` e.g. something like `CastFunctionMiscLegacyITCase` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
