netvl commented on code in PR #22854:
URL: https://github.com/apache/flink/pull/22854#discussion_r1241044829
##########
flink-runtime/src/main/java/org/apache/flink/runtime/messages/ThreadInfoSample.java:
##########
@@ -38,7 +42,7 @@ public class ThreadInfoSample implements Serializable {
private ThreadInfoSample(Thread.State threadState, StackTraceElement[]
stackTrace) {
this.threadState = threadState;
- this.stackTrace = stackTrace;
+ this.stackTrace = cleanLambdaNames(stackTrace);
Review Comment:
I looked into how this class is used, and it appears that its
stacktrace-related functionality is only used for flame graphs (and I think it
was added for flame graphs specifically).
Doing this cleanup as close to the place where stack traces are created
results in cleaner code, and I personally think it is highly unlikely for the
class name change to affect anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
