1996fanrui commented on code in PR #22854:
URL: https://github.com/apache/flink/pull/22854#discussion_r1241140276
##########
flink-runtime/src/main/java/org/apache/flink/runtime/messages/ThreadInfoSample.java:
##########
@@ -38,7 +42,7 @@ public class ThreadInfoSample implements Serializable {
private ThreadInfoSample(Thread.State threadState, StackTraceElement[]
stackTrace) {
this.threadState = threadState;
- this.stackTrace = stackTrace;
+ this.stackTrace = cleanLambdaNames(stackTrace);
Review Comment:
Currently, the `ThreadInfoSample ` is just used for flame graph. However,
it's a common class.
The lambda name just effects the flame graph, so I prefer clean LambdaNames
at the flame graph side, it's more clear, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
