XComp opened a new pull request, #22865: URL: https://github.com/apache/flink/pull/22865
## What is the purpose of the change The purpose of `EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown` is to check that there is no `NullPointerException` happening if the event processing happens after the shutdown of the `EmbeddedExecutorService` (see [FLINK-11855](https://issues.apache.org/jira/browse/FLINK-11855)). The concurrent execution is not handled properly, though. The test also succeeds if the close call happened before the shutdown (due to the multi-threaded nature of the test) which leaves us without the actual test scenario being tested. ## Brief change log * Introduced `ManuallyTriggeredScheduledExecutorService` * Added proper asserts * hotfix: Migrated `EmbeddedLeaderServiceTest` to JUnit5/AssertJ ## Verifying this change Trivial change: The refactored tests should pass. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
