hanyuzheng7 commented on code in PR #22730:
URL: https://github.com/apache/flink/pull/22730#discussion_r1242399052
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java:
##########
@@ -479,4 +480,165 @@ private Stream<TestSetSpec> arrayUnionTestCases() {
"Invalid input arguments. Expected signatures
are:\n"
+ "ARRAY_UNION(<COMMON>, <COMMON>)"));
}
+
+ private Stream<TestSetSpec> arrayMaxTestCases() {
+ return Stream.of(
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.ARRAY_MAX)
+ .onFieldsWithData(
+ new Integer[] {1, 2, null},
+ null,
+ new Double[] {1.2, null, 3.4, 8.0},
+ new String[] {"a", null, "bc", "d", "def"},
+ new Row[] {
+ Row.of(true, LocalDate.of(2022, 4, 20)),
+ Row.of(true, LocalDate.of(1990, 10, 14)),
+ null
+ },
+ new Map[] {
+ CollectionUtil.map(entry(1, "a"), entry(2,
"b")),
+ CollectionUtil.map(entry(3, "c"), entry(4,
"d")),
+ null
+ },
+ new Integer[][] {{1, 2, 3}, {4, 5, 6}, {7, 8,
9}, null},
+ new Row[] {
+ Row.of(LocalDate.of(2022, 4, 20)),
+ Row.of(LocalDate.of(1990, 10, 14)),
+ Row.of(LocalDate.of(2022, 4, 20)),
+ Row.of(LocalDate.of(1990, 10, 14)),
+ Row.of(LocalDate.of(2022, 4, 20)),
+ Row.of(LocalDate.of(1990, 10, 14)),
+ null
+ },
+ new Boolean[] {true, false, true, false, true,
null},
+ new Row[] {
+ Row.of(true),
+ Row.of(false),
+ Row.of(true),
+ Row.of(false),
+ Row.of(true),
+ Row.of(false),
+ null
+ },
+ new Row[] {
+ Row.of(1), Row.of(2), Row.of(8),
Row.of(4), Row.of(5),
+ Row.of(8), null
+ },
+ 1,
+ 1.5,
+ "abc",
+ new Integer[][] {{1, 2}, {2, 3}, null},
+ new LocalDate[] {
+ LocalDate.of(2022, 1, 2),
+ LocalDate.of(2023, 4, 21),
+ LocalDate.of(2022, 12, 24),
+ LocalDate.of(2026, 2, 10),
+ LocalDate.of(2012, 5, 16),
+ LocalDate.of(2092, 7, 19)
+ })
+ .andDataTypes(
+ DataTypes.ARRAY(DataTypes.INT()),
+ DataTypes.ARRAY(DataTypes.INT()),
+ DataTypes.ARRAY(DataTypes.DOUBLE()),
+ DataTypes.ARRAY(DataTypes.STRING()),
+ DataTypes.ARRAY(
+ DataTypes.ROW(DataTypes.BOOLEAN(),
DataTypes.DATE())),
+ DataTypes.ARRAY(DataTypes.MAP(DataTypes.INT(),
DataTypes.STRING())),
+
DataTypes.ARRAY(DataTypes.ARRAY(DataTypes.INT())),
+
DataTypes.ARRAY(DataTypes.ROW(DataTypes.DATE())),
+ DataTypes.ARRAY(DataTypes.BOOLEAN()),
+
DataTypes.ARRAY(DataTypes.ROW(DataTypes.BOOLEAN())),
+
DataTypes.ARRAY(DataTypes.ROW(DataTypes.INT())),
+ DataTypes.INT().notNull(),
+ DataTypes.DOUBLE().notNull(),
+ DataTypes.STRING().notNull(),
+
DataTypes.ARRAY(DataTypes.ARRAY(DataTypes.INT())),
+ DataTypes.ARRAY(DataTypes.DATE()))
+ .testResult($("f0").arrayMax(), "ARRAY_MAX(f0)", 2,
DataTypes.INT())
+ .testResult($("f1").arrayMax(), "ARRAY_MAX(f1)", null,
DataTypes.INT())
+ .testResult($("f2").arrayMax(), "ARRAY_MAX(f2)", 8.0,
DataTypes.DOUBLE())
+ .testResult($("f3").arrayMax(), "ARRAY_MAX(f3)",
"def", DataTypes.STRING())
+ .testResult(
+ $("f15").arrayMax(),
+ "ARRAY_MAX(f15)",
+ LocalDate.of(2092, 7, 19),
+ DataTypes.DATE())
+ .testSqlValidationError(
+ "ARRAY_MAX(f4)",
+ "SQL validation failed. Invalid function
call:\n"
+ + "ARRAY_MAX(ARRAY<ROW<`f0` BOOLEAN,
`f1` DATE>>")
+ .testTableApiValidationError(
+ $("f4").arrayMax(),
+ "Invalid function call:\n"
+ + "ARRAY_MAX(ARRAY<ROW<`f0` BOOLEAN,
`f1` DATE>>")
+ .testSqlValidationError(
+ "ARRAY_MAX(f5)",
+ "SQL validation failed. Invalid function
call:\n"
+ + "ARRAY_MAX(ARRAY<MAP<INT, STRING>>")
+ .testTableApiValidationError(
+ $("f5").arrayMax(),
+ "Invalid function call:\n" +
"ARRAY_MAX(ARRAY<MAP<INT, STRING>>)")
+ .testSqlValidationError(
+ "ARRAY_MAX(f6)",
+ "SQL validation failed. Invalid function
call:\n"
+ + "ARRAY_MAX(ARRAY<ARRAY<INT>>)")
+ .testTableApiValidationError(
+ $("f6").arrayMax(),
+ "Invalid function call:\n" +
"ARRAY_MAX(ARRAY<ARRAY<INT>>)")
+ .testSqlValidationError(
Review Comment:
Yes, it seem that we cannot compare constructed types. Because it is unable
to create an expression evaluator for expression
```
Caused by: org.apache.flink.table.planner.codegen.CodeGenException:
Comparable type expected, but was 'ROW<`f0` BOOLEAN, `f1` DATE> NOT NULL'.
at
org.apache.flink.table.planner.codegen.CodeGenUtils$.requireComparable(CodeGenUtils.scala:399)
```
and because it will call this function
```
public static boolean isComparable(LogicalType type) {
return !isRaw(type) && !isMap(type) && !isMultiset(type) &&
!isRow(type) && !isArray(type);
}
```
so we cannot compare these type, even they are constructed typed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
