hanyuzheng7 commented on code in PR #22730:
URL: https://github.com/apache/flink/pull/22730#discussion_r1242457763


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java:
##########
@@ -1407,6 +1408,15 @@ public OutType arrayUnion(InType array) {
                 unresolvedCall(ARRAY_UNION, toExpr(), 
objectToExpression(array)));
     }
 
+    /**
+     * Return an element that is the maximum element in the array.
+     *
+     * <p>if array itself is null, the * function will return null.

Review Comment:
   fixed it.



##########
flink-python/pyflink/table/expression.py:
##########
@@ -1519,6 +1519,13 @@ def array_union(self, array) -> 'Expression':
         """
         return _binary_op("arrayUnion")(self, array)
 
+    def array_max(self) -> 'Expression':
+        """
+        Return the element that this element is the maximum one in the array
+        If the array is null, the function will return null.

Review Comment:
   fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to