rkhachatryan commented on code in PR #22787:
URL: https://github.com/apache/flink/pull/22787#discussion_r1244318482
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -597,8 +597,7 @@ protected void processInput(MailboxDefaultAction.Controller
controller) throws E
resumeFuture = inputProcessor.getAvailableFuture();
} else if (changelogWriterAvailabilityProvider != null) {
// currently, waiting for changelog availability is reported as
busy
- // todo: add new metric (FLINK-24402)
- timer = null;
+ timer = new
GaugePeriodTimer(ioMetrics.getIoBackPressuredTimePerSecond());
Review Comment:
Yes, sorry, that's what I wanted to say: "backpressured", not "idle".
So should the documentation be updated then?
E.g. in
https://nightlies.apache.org/flink/flink-docs-master/docs/ops/monitoring/back_pressure/
> Internally, back pressure is judged based on the availability of output
buffers. If a task has no available output buffers, then that task is
considered back pressured. Idleness, on the other hand, is determined by
whether or not there is input available.
(and the highlighted comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
