rkhachatryan commented on code in PR #22787:
URL: https://github.com/apache/flink/pull/22787#discussion_r1242463807
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -597,8 +597,7 @@ protected void processInput(MailboxDefaultAction.Controller
controller) throws E
resumeFuture = inputProcessor.getAvailableFuture();
} else if (changelogWriterAvailabilityProvider != null) {
// currently, waiting for changelog availability is reported as
busy
- // todo: add new metric (FLINK-24402)
- timer = null;
+ timer = new
GaugePeriodTimer(ioMetrics.getIoBackPressuredTimePerSecond());
Review Comment:
The comment above is no longer true with this change, right?
When a task is waiting for changelog availability (but not blocked in
writer), it will be reported as idle.
Won't such a change without adjusting the UI be confusing to the users?
cc: @pnowojski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
