lincoln-lil opened a new pull request, #22894:
URL: https://github.com/apache/flink/pull/22894
## What is the purpose of the change
When compile from an exist compiled plan which contains watermark
declaration and it referred the metadata column, the generated code for
WatermarkGenerator maybe wrong, this is because currently
`DynamicTableSourceSpec`.getTableSource passes the user defined schema to
`SourceAbilitySpec` to perform optimization like projection/watermark pushdown,
while optimization path from sql use a fixed reordering form: "PHYSICAL COLUMNS
+ METADATA COLUMNS", this may cause the problem. We should keep the logic
consistently.
## Brief change log
use DynamicSourceUtils.createProducedType to produce the type info which
keeps consistent with sql2Rel phase
## Verifying this change
add test cases to `WatermarkAssignerJsonPlanITCase` & `CalcJsonPlanTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
@Public(Evolving): (no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
