z3d1k commented on code in PR #85:
URL:
https://github.com/apache/flink-connector-aws/pull/85#discussion_r1247912712
##########
flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkWriterTest.java:
##########
@@ -68,17 +69,19 @@ public class DynamoDbSinkWriterTest {
public void testSuccessfulRequestWithNoDeduplication() throws Exception {
List<String> overwriteByPartitionKeys = Collections.emptyList();
List<DynamoDbWriteRequest> inputRequests =
- ImmutableList.of(
- sinkPutRequest(item("pk", "1")),
- sinkPutRequest(item("pk", "2")),
- sinkDeleteRequest(item("pk", "3")),
- sinkDeleteRequest(item("pk", "4")));
+ Stream.of(
+ sinkPutRequest(item("pk", "1")),
+ sinkPutRequest(item("pk", "2")),
+ sinkDeleteRequest(item("pk", "3")),
+ sinkDeleteRequest(item("pk", "4")))
+ .collect(toList());
Review Comment:
or use `.collect(toUnmodifiableList())` to preserve immutable semantics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
