MartijnVisser commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247980121
##########
flink-connector-kafka/pom.xml:
##########
@@ -72,6 +72,13 @@ under the License.
<version>${kafka.version}</version>
</dependency>
+ <!-- When flink-core bump to commons-collections4, we can remove it.-->
Review Comment:
With the externalization of connectors, we shouldn't have the connector
depend on an artifact that may or may not be bundled with Flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
