chucheng92 commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1248008592
##########
flink-connector-kafka/pom.xml:
##########
@@ -72,6 +72,13 @@ under the License.
<version>${kafka.version}</version>
</dependency>
+ <!-- When flink-core bump to commons-collections4, we can remove it.-->
Review Comment:
> Another way is flink keep commons-collections 3.x remained and add
commons-collections4. then kafka connector in this repo update to
commons-collections4 (just replace package name, no dependency import), and
flink remove commons-collections 3.x. it's
[flink-side](https://issues.apache.org/jira/browse/FLINK-side) solution. what
do u think?
@MartijnVisser Whether we can keep these 2 version in flink temporarily?
In fact, spark also encounters similar problems (but not reference loop),
and currently two versions coexist.
https://github.com/apache/spark/pull/35257
https://github.com/apache/spark/pull/36009/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
