dannycranmer commented on code in PR #21458:
URL: https://github.com/apache/flink/pull/21458#discussion_r1248002523
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java:
##########
@@ -126,7 +126,16 @@ public long getPos() throws IOException {
@Override
public void sync() throws IOException {
- fileStream.sync();
Review Comment:
@Samrat002 this is concerning me: "The S3 file system connector: (yes / no /
don't know) maybe". When is this method called? Is it possible we can violate
the semantics of the 2-phase commit File Sink here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
