wuchong commented on code in PR #22734:
URL: https://github.com/apache/flink/pull/22734#discussion_r1248506769
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GeneratedExpression.scala:
##########
@@ -39,7 +39,7 @@ import org.apache.flink.table.types.logical.LogicalType
case class GeneratedExpression(
resultTerm: String,
nullTerm: String,
- code: String,
+ var code: String,
Review Comment:
Just make a copy of `GeneratedExpression` with `exp.copy(code = NO_CODE)`.
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala:
##########
@@ -449,14 +449,17 @@ object GenerateUtils {
* whether the input is nullable
* @param deepCopy
* whether to copy the accessed field (usually needed when buffered)
+ * @param fusionCodegen
+ * if fusion codegen enabled, don't need to hide generated code
Review Comment:
I don't fully understand. If some fields can be pruned, why not the
optimizer remove the fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
