chucheng92 commented on code in PR #22888: URL: https://github.com/apache/flink/pull/22888#discussion_r1251416413
########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowProcedures.java: ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.dql; + +import org.apache.calcite.sql.SqlCall; +import org.apache.calcite.sql.SqlCharStringLiteral; +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.sql.parser.SqlParserPos; + +import javax.annotation.Nullable; + +import java.util.Collections; +import java.util.List; +import java.util.Objects; + +import static java.util.Objects.requireNonNull; + +/** + * SHOW PROCEDURES sql call. The full syntax for show procedures is as followings: + * + * <pre>{@code + * SHOW PROCEDURES [ ( FROM | IN ) [catalog_name.]database_name ] [ [NOT] (LIKE | ILIKE) + * <sql_like_pattern> ] statement + * }</pre> + */ +public class SqlShowProcedures extends SqlCall { + + public static final SqlSpecialOperator OPERATOR = + new SqlSpecialOperator("SHOW PROCEDURES", SqlKind.OTHER); + + @Nullable private final SqlIdentifier databaseName; + @Nullable private final String preposition; + private final boolean notLike; + // different like type such as like, ilike + @Nullable private final String likeType; + @Nullable private final SqlCharStringLiteral likeLiteral; + + public SqlShowProcedures( + SqlParserPos pos, + @Nullable String preposition, + @Nullable SqlIdentifier databaseName, + boolean notLike, + @Nullable String likeType, Review Comment: shall we do a check here? if likeType is not null then likeLiteral can not be null either, just like your databaseName checking. ########## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowProceduresOperation.java: ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.operations; + +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.api.internal.TableResultInternal; +import org.apache.flink.table.catalog.Catalog; +import org.apache.flink.table.catalog.CatalogManager; +import org.apache.flink.table.catalog.exceptions.DatabaseNotExistException; +import org.apache.flink.table.functions.SqlLikeUtils; + +import javax.annotation.Nullable; + +import java.util.List; + +import static org.apache.flink.table.api.internal.TableResultUtils.buildStringArrayResult; + +/** + * Operation to describe a SHOW PROCEDURES [ ( FROM | IN ) [catalog_name.]database_name ] [ [NOT] + * (LIKE | ILIKE) <sql_like_pattern> ] statement. + */ +public class ShowProceduresOperation implements ExecutableOperation { + + private final @Nullable String catalogName; + + private final @Nullable String databaseName; + private final @Nullable String preposition; + + private final boolean notLike; + + // different like type such as like, ilike + private final LikeType likeType; + + @Nullable private final String sqlLikePattern; + + public ShowProceduresOperation(boolean isNotLike, String likeType, String sqlLikePattern) { + this(null, null, null, isNotLike, likeType, sqlLikePattern); + } + + public ShowProceduresOperation( + @Nullable String preposition, + @Nullable String catalogName, + @Nullable String databaseName, + boolean notLike, + @Nullable String likeType, + @Nullable String sqlLikePattern) { + this.preposition = preposition; + this.catalogName = catalogName; + this.databaseName = databaseName; + this.notLike = notLike; + this.likeType = likeType == null ? null : LikeType.of(likeType); Review Comment: just like SqlShowProcedure, can we add a check for sqlLikePattern if sqlLikePattern is not null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
