snuyanzin commented on code in PR #22842:
URL: https://github.com/apache/flink/pull/22842#discussion_r1252336736
##########
docs/data/sql_functions.yml:
##########
@@ -658,6 +658,9 @@ collection:
- sql: MAP_KEYS(map)
table: MAP.mapKeys()
description: Returns the keys of the map as array. No order guaranteed.
+ - sql: MAP_UNION(map1, map2)
+ table: map1.mapUnion(map2)
+ description: Returns a map created by merging two maps, 'map1' and 'map2'.
These two maps should have same data structure. If there are overlapping keys,
the value from 'map2' will overwrite the value from 'map1'. If any of maps is
null, return null.
Review Comment:
it's not clear what is same datastructure in SQL context...
i guess same type (or not same, however common)
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java:
##########
@@ -1468,6 +1469,16 @@ public OutType mapEntries() {
return toApiSpecificExpression(unresolvedCall(MAP_ENTRIES, toExpr()));
}
+ /**
+ * Returns a map created by merging two maps, 'map1' and 'map2'. These two
maps should have same
+ * data structure. If there are overlapping keys, the value from 'map2'
will overwrite the value
Review Comment:
it's not clear what is same datastructure in SQL context...
i guess same type (or not same, however common)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
