snuyanzin commented on code in PR #22842:
URL: https://github.com/apache/flink/pull/22842#discussion_r1252354619


##########
flink-python/pyflink/table/expression.py:
##########
@@ -1558,6 +1558,18 @@ def map_keys(self) -> 'Expression':
         """
         return _unary_op("mapKeys")(self)
 
+    @property
+    def map_union(self, map2) -> 'Expression':
+        """
+        Returns a map created by merging two maps, 'map1' and 'map2'.
+        These two maps should have same data structure. If there are 
overlapping keys,

Review Comment:
   you can not say `same` since  one could be nullable and another not...
   so it should be common type



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to