[
https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741045#comment-17741045
]
Etienne Chauchot edited comment on FLINK-32563 at 7/7/23 1:49 PM:
------------------------------------------------------------------
[~martijnvisser]
> From the discussion thread I read it as that you want to be able to skip
> archunit for specific versions?
Yes, disable it for all the versions except the main supported by the connector
> See
> [https://github.com/apache/flink-connector-shared-utils/blob/ci_utils/.github/workflows/_testing.yml#L25-L28]
I did not know _{_}testing.yml{_} workflow. What is the link with
connector/push_pr.yml ? I see both of them call {_}ci.yml@ci_utils{_}. Also
both run ci.yml workflow on various flink versions but only push_pr.yml allows
the connector author to specify which flink versions to test his connector
against.
was (Author: echauchot):
[~martijnvisser]
> From the discussion thread I read it as that you want to be able to skip
> archunit for specific versions?
Yes, disable it for all the versions except the main supported by the connector
> See
> [https://github.com/apache/flink-connector-shared-utils/blob/ci_utils/.github/workflows/_testing.yml#L25-L28]
I did not know __testing.yml_ workflow. What is the link with
connector/push_pr.yml ? I see both of them call _ci.yml@ci_utils{_}. Also both
run this workflow on various flink versions but only push_pr.yml allows the
connector author to specify flink version to test his connector against.
> Allow connectors CI to specify the main supported Flink version
> ---------------------------------------------------------------
>
> Key: FLINK-32563
> URL: https://issues.apache.org/jira/browse/FLINK-32563
> Project: Flink
> Issue Type: Technical Debt
> Components: Build System / CI
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
>
> As part of [this
> discussion|https://lists.apache.org/thread/pr0g812olzpgz21d9oodhc46db9jpxo3]
> , the need for connectors to specify the main flink version that a connector
> supports has arisen.
> This CI variable will allow to configure the build and tests differently
> depending on this version. This parameter would be optional.
> The first use case is to run archunit tests only on the main supported
> version as discussed in the above thread.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
