patricklucas opened a new pull request, #22987:
URL: https://github.com/apache/flink/pull/22987
## What is the purpose of the change
Fix the issue described in FLINK-32583 wherein a request made to a
RestClient that has already been shutdown can deadlock due to the returned
future never resolving.
## Brief change log
- Add check if the Netty channel future has already failed after attempting
to add a listener to it
## Verifying this change
This change added tests and can be verified as follows:
- Added test for this behavior in RestClientTest,
`testCloseClientBeforeRequest`
- This test calls `restClient.close()` and then attempts to make a request
that would eventually fail with a connection timeout
- The test blocks on the future returned by the call with a timeout of 0
so it can test that the expected exception (and not TimeoutException) is thrown
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
