1996fanrui commented on PR #22761: URL: https://github.com/apache/flink/pull/22761#issuecomment-1635674114
Thanks for your quick review again! > Don't forget to squash your commits before merging as soon as the tests are green. Done. > It also makes sense to check the benchmarks since this code is sensitive to performance(at least you can take a look at benchmarks after the merge to be sure that nothing was degraded. Sorry, I don't know why this PR is sensitive to performance, I may have missed some background. As I understand, it just add buffer through ResultPartition instead of adding buffer to Subpartition directly. Could you give more information? thanks a lot. BTW, do you think this fix should be backported to 1.17 and 1.16? It's a bug, however it only affects the metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
