[
https://issues.apache.org/jira/browse/FLINK-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621599#comment-15621599
]
ASF GitHub Bot commented on FLINK-4923:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2727#discussion_r85698371
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
---
@@ -111,6 +111,11 @@ public int getNumBuffers() {
}
@Override
+ public int getNumberOfUsedBuffers() {
+ return numberOfRequestedMemorySegments -
getNumberOfAvailableMemorySegments();
--- End diff --
instead of `getNumberOfAvailableMemorySegments()` we could use
`availableMemorySegments.size()` so we never enter a synchronized block and
affect the LocalBufferPool.
> Expose input/output buffers and bufferPool usage as a metric for a Task
> -----------------------------------------------------------------------
>
> Key: FLINK-4923
> URL: https://issues.apache.org/jira/browse/FLINK-4923
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Reporter: zhuhaifeng
> Assignee: zhuhaifeng
> Priority: Minor
> Fix For: 1.2.0
>
>
> We should expose the following Metrics on the TaskIOMetricGroup:
> 1. Buffers.inputQueueLength: received buffers of InputGates for a task
> 2. Buffers.outputQueueLength: buffers of produced ResultPartitions for a task
> 3. Buffers.inPoolUsage: usage of InputGates buffer pool for a task
> 4. Buffers.outPoolUsage: usage of produced ResultPartitions buffer pool for
> a task
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
