XComp commented on code in PR #22996:
URL: https://github.com/apache/flink/pull/22996#discussion_r1269509117
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaUtils.java:
##########
@@ -462,17 +463,17 @@ public static Config getAkkaConfig(
}
/**
- * Creates an akka config with the provided configuration values. If the
listening address is
+ * Creates an pekko config with the provided configuration values. If the
listening address is
* specified, then the actor system will listen on the respective address.
*
* @param configuration instance containing the user provided
configuration values
* @param externalAddress optional tuple of external address and port to
be reachable at. If
- * null is given, then an Akka config for local actor system will be
returned
+ * null is given, then an Pekko config for local actor system will be
returned
Review Comment:
```suggestion
* null is given, then a Pekko config for local actor system will be
returned
```
nit
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java:
##########
@@ -41,9 +41,10 @@
public class RpcUtils {
/**
- * <b>HACK:</b> Set to 21474835 seconds, Akka's maximum delay (Akka
2.4.20). The value cannot be
- * higher or an {@link IllegalArgumentException} will be thrown during an
RPC. Check the private
- * method {@code checkMaxDelay()} in {@link
akka.actor.LightArrayRevolverScheduler}.
+ * <b>HACK:</b> Set to 21474835 seconds, Pekko's maximum delay (Akka
2.4.20). The value cannot
Review Comment:
```suggestion
* <b>HACK:</b> Set to 21474835 seconds, Pekko's maximum delay (Pekko
1.0.0). The value cannot
```
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaUtils.java:
##########
@@ -462,17 +463,17 @@ public static Config getAkkaConfig(
}
/**
- * Creates an akka config with the provided configuration values. If the
listening address is
+ * Creates an pekko config with the provided configuration values. If the
listening address is
Review Comment:
```suggestion
* Creates a pekko config with the provided configuration values. If the
listening address is
```
nit
##########
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java:
##########
@@ -337,7 +358,7 @@ public static boolean
isForceRpcInvocationSerializationEnabled(Configuration con
+ " Higher value increases
the time to detect a dead TaskManager. A thorough description of Akka’s"
Review Comment:
```suggestion
+ " Higher value
increases the time to detect a dead TaskManager. A thorough description of
Pekko's"
```
##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java:
##########
@@ -41,9 +41,10 @@
public class RpcUtils {
/**
- * <b>HACK:</b> Set to 21474835 seconds, Akka's maximum delay (Akka
2.4.20). The value cannot be
- * higher or an {@link IllegalArgumentException} will be thrown during an
RPC. Check the private
- * method {@code checkMaxDelay()} in {@link
akka.actor.LightArrayRevolverScheduler}.
+ * <b>HACK:</b> Set to 21474835 seconds, Pekko's maximum delay (Akka
2.4.20). The value cannot
+ * be higher or an {@link IllegalArgumentException} will be thrown during
an RPC. Check the
+ * private method {@code checkMaxDelay()} in {@link
+ * org.apache.pekko.actor.LightArrayRevolverScheduler}.
Review Comment:
```suggestion
* org.apache.pekko.actor.LightArrayRevolverScheduler}.
```
That's odd: My Intellij isn't able to resolve the reference even though it's
the correct location. :thinking: It even suggests this class name when trying
to fix the error
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaUtils.java:
##########
@@ -433,23 +434,23 @@ public static ActorSystem createDefaultActorSystem() {
}
/**
- * Creates the default akka configuration which listens on a random port
on the local machine.
+ * Creates the default pekko configuration which listens on a random port
on the local machine.
* All configuration values are set to default values.
*
- * @return Flink's Akka default config
+ * @return Flink's Pekko default config
*/
private static Config getDefaultAkkaConfig() {
return getAkkaConfig(new Configuration(), new HostAndPort("", 0));
}
/**
- * Creates an akka config with the provided configuration values. If the
listening address is
+ * Creates a pekko config with the provided configuration values. If the
listening address is
* specified, then the actor system will listen on the respective address.
*
* @param configuration instance containing the user provided
configuration values
* @param externalAddress optional tuple of bindAddress and port to be
reachable at. If null is
- * given, then an Akka config for local actor system will be returned
- * @return Akka config
+ * given, then an Pekko config for local actor system will be returned
Review Comment:
```suggestion
* given, then a Pekko config for local actor system will be returned
```
nit: since you fixed it properly in the JavaDoc above :man_shrugging:
##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/ContextClassLoadingSettingTest.java:
##########
Review Comment:
nit: JavaDoc contains "akka" twice
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/DeadLettersActor.java:
##########
Review Comment:
The JavaDoc refers to the Akka class `DeadLetter` but should rather point to
the corresponding Pekko class.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/net/ConnectionUtils.java:
##########
@@ -416,12 +416,12 @@ public InetAddress findConnectingAddress(Duration
timeout, Duration startLogging
+ "while waiting for the
leader retrieval.");
}
} else if (retrievalState ==
LeaderRetrievalState.NEWLY_RETRIEVED) {
- targetAddress =
rpcSystemUtils.getInetSocketAddressFromRpcUrl(akkaURL);
+ targetAddress =
rpcSystemUtils.getInetSocketAddressFromRpcUrl(rpcURL);
LOG.debug(
"Retrieved new target address {} for akka
URL {}.",
Review Comment:
```suggestion
"Retrieved new target address {} for RPC
URL {}.",
```
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/PriorityThreadsDispatcher.java:
##########
Review Comment:
The constructors JavaDoc has two occurrences of the `Akka` term.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java:
##########
@@ -89,7 +89,7 @@ private UnmodifiableConfiguration generateConfiguration(final
Configuration conf
modifiedConfig.set(ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE,
DEFAULT_IO_POOL_SIZE);
}
- // increase the akka.ask.timeout if not set in order to harden tests
on slow CI
+ // increase the ask.timeout if not set in order to harden tests on
slow CI
Review Comment:
I guess it makes sense to remove the prefix :+1:
##########
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java:
##########
@@ -314,7 +335,7 @@ public static boolean
isForceRpcInvocationSerializationEnabled(Configuration con
+ " should decrease this
value or increase akka.watch.heartbeat.pause. A thorough description of"
+ " Akka’s DeathWatch can
be found %s",
Review Comment:
```suggestion
+ " Pekko’s DeathWatch
can be found %s",
```
##########
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java:
##########
@@ -358,7 +379,7 @@ public static boolean
isForceRpcInvocationSerializationEnabled(Configuration con
+ " a high value increases
the time to detect a dead TaskManager. A thorough description of Akka’s"
Review Comment:
```suggestion
+ " a high value
increases the time to detect a dead TaskManager. A thorough description of
Pekko's"
```
##########
flink-core/src/main/java/org/apache/flink/util/NetUtils.java:
##########
@@ -195,8 +195,9 @@ public static Port getAvailablePort() {
// ------------------------------------------------------------------------
/**
- * Returns an address in a normalized format for Akka. When an IPv6
address is specified, it
- * normalizes the IPv6 address to avoid complications with the exact URL
match policy of Akka.
+ * Returns an address in a normalized format for AkPekkoka. When an IPv6
address is specified,
Review Comment:
```suggestion
* Returns an address in a normalized format for Pekko. When an IPv6
address is specified,
```
That's kind of funny :-D
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java:
##########
@@ -80,8 +80,8 @@
import static org.apache.flink.util.Preconditions.checkState;
/**
- * Akka based {@link RpcService} implementation. The RPC service starts an
Akka actor to receive RPC
- * invocations from a {@link RpcGateway}.
+ * Pekko based {@link RpcService} implementation. The RPC service starts an
Akka actor to receive
Review Comment:
```suggestion
* Pekko based {@link RpcService} implementation. The RPC service starts an
actor to receive
```
##########
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java:
##########
@@ -69,9 +71,10 @@ public static boolean
isForceRpcInvocationSerializationEnabled(Configuration con
/** Timeout for akka ask calls. */
Review Comment:
```suggestion
/** Timeout for pekko ask calls. */
```
It might be reasonable to modify the JavaDoc here (and the other AkkaOptions
entries) as well. ...since we're touching JavaDoc in other cases as well.
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaUtils.java:
##########
@@ -137,7 +137,7 @@ public static Config getThreadPoolExecutorConfig(
final int maxNumThreads = configuration.getMaxNumThreads();
return new AkkaConfigBuilder()
- .add("akka {")
+ .add("pekko {")
.add(" actor {")
.add(" default-dispatcher {")
.add(" type =
org.apache.flink.runtime.rpc.akka.PriorityThreadsDispatcher")
Review Comment:
That's a bit off-topic (hotfix) but could we add a JavaDoc to this method
that mentions `PriorityThreadsDispatcher`? Initially, I got confused by
Intellij telling me that `PriorityThreadsDispatcher` is an "unused" class.
Adding a descriptive JavaDoc here would make this issue go away.
##########
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java:
##########
@@ -314,7 +335,7 @@ public static boolean
isForceRpcInvocationSerializationEnabled(Configuration con
+ " should decrease this
value or increase akka.watch.heartbeat.pause. A thorough description of"
+ " Akka’s DeathWatch can
be found %s",
Review Comment:
```suggestion
+ " Pekko’s DeathWatch
can be found %s",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
