XComp commented on code in PR #22996:
URL: https://github.com/apache/flink/pull/22996#discussion_r1272361814
##########
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java:
##########
@@ -58,26 +59,30 @@ public static boolean
isForceRpcInvocationSerializationEnabled(Configuration con
/** Flag whether to capture call stacks for RPC ask calls. */
public static final ConfigOption<Boolean> CAPTURE_ASK_CALLSTACK =
- ConfigOptions.key("akka.ask.callstack")
+ ConfigOptions.key("pekko.ask.callstack")
.booleanType()
.defaultValue(true)
+ .withDeprecatedKeys("akka.ask.callstack")
.withDescription(
"If true, call stack for asynchronous asks are
captured. That way, when an ask fails "
+ "(for example times out), you get a
proper exception, describing to the original method call and "
+ "call site. Note that in case of having
millions of concurrent RPC calls, this may add to the "
+ "memory footprint.");
- /** Timeout for akka ask calls. */
+ /** Timeout for Pekko ask calls. */
public static final ConfigOption<Duration> ASK_TIMEOUT_DURATION =
- ConfigOptions.key("akka.ask.timeout")
+ ConfigOptions.key("pekko.ask.timeout")
.durationType()
.defaultValue(Duration.ofSeconds(10))
+ .withDeprecatedKeys("akka.ask.timeout")
.withDescription(
- "Timeout used for all futures and blocking Akka
calls. If Flink fails due to timeouts then you"
+ "Timeout used for all futures and blocking Pekko
calls. If Flink fails due to timeouts then you"
+ " should try to increase this value.
Timeouts can be caused by slow machines or a congested network. The"
+ " timeout value requires a time-unit
specifier (ms/s/min/h/d).");
- /** @deprecated Use {@link #ASK_TIMEOUT_DURATION} */
Review Comment:
Why did that change?
##########
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java:
##########
@@ -86,69 +91,78 @@ public static boolean
isForceRpcInvocationSerializationEnabled(Configuration con
TimeUtils.formatWithHighestUnit(ASK_TIMEOUT_DURATION.defaultValue()))
.withDescription(ASK_TIMEOUT_DURATION.description());
- /** The Akka tcp connection timeout. */
+ /** The Pekko tcp connection timeout. */
public static final ConfigOption<String> TCP_TIMEOUT =
- ConfigOptions.key("akka.tcp.timeout")
+ ConfigOptions.key("pekko.tcp.timeout")
.stringType()
.defaultValue("20 s")
+ .withDeprecatedKeys("akka.tcp.timeout")
.withDescription(
"Timeout for all outbound connections. If you
should experience problems with connecting to a"
+ " TaskManager due to a slow network, you
should increase this value.");
/** Timeout for the startup of the actor system. */
public static final ConfigOption<String> STARTUP_TIMEOUT =
- ConfigOptions.key("akka.startup-timeout")
+ ConfigOptions.key("pekko.startup-timeout")
.stringType()
.noDefaultValue()
+ .withDeprecatedKeys("akka.startup-timeout")
.withDescription(
"Timeout after which the startup of a remote
component is considered being failed.");
- /** Override SSL support for the Akka transport. */
+ /** Override SSL support for the Pekko transport. */
public static final ConfigOption<Boolean> SSL_ENABLED =
- ConfigOptions.key("akka.ssl.enabled")
+ ConfigOptions.key("pekko.ssl.enabled")
.booleanType()
.defaultValue(true)
+ .withDeprecatedKeys("akka.ssl.enabled")
.withDescription(
"Turns on SSL for Akka’s remote communication.
This is applicable only when the global ssl flag"
+ " security.ssl.enabled is set to true.");
- /** Maximum framesize of akka messages. */
+ /** Maximum framesize of Pekko messages. */
public static final ConfigOption<String> FRAMESIZE =
- ConfigOptions.key("akka.framesize")
+ ConfigOptions.key("pekko.framesize")
.stringType()
.defaultValue("10485760b")
+ .withDeprecatedKeys("akka.framesize")
.withDescription(
"Maximum size of messages which are sent between
the JobManager and the TaskManagers. If Flink"
+ " fails because messages exceed this
limit, then you should increase it. The message size requires a"
+ " size-unit specifier.");
/** Maximum number of messages until another actor is executed by the same
thread. */
public static final ConfigOption<Integer> DISPATCHER_THROUGHPUT =
- ConfigOptions.key("akka.throughput")
+ ConfigOptions.key("pekko.throughput")
.intType()
.defaultValue(15)
+ .withDeprecatedKeys("akka.throughput")
.withDescription(
"Number of messages that are processed in a batch
before returning the thread to the pool. Low"
+ " values denote a fair scheduling
whereas high values can increase the performance at the cost of unfairness.");
/** Log lifecycle events. */
public static final ConfigOption<Boolean> LOG_LIFECYCLE_EVENTS =
- ConfigOptions.key("akka.log.lifecycle.events")
+ ConfigOptions.key("pekko.log.lifecycle.events")
.booleanType()
.defaultValue(false)
+ .withDeprecatedKeys("akka.log.lifecycle.events")
.withDescription(
- "Turns on the Akka’s remote logging of events. Set
this value to 'true' in case of debugging.");
+ "Turns on the Pekko’s remote logging of events.
Set this value to 'true' in case of debugging.");
/** Timeout for all blocking calls that look up remote actors. */
public static final ConfigOption<Duration> LOOKUP_TIMEOUT_DURATION =
- ConfigOptions.key("akka.lookup.timeout")
+ ConfigOptions.key("pekko.lookup.timeout")
.durationType()
.defaultValue(Duration.ofSeconds(10))
+ .withDeprecatedKeys("akka.lookup.timeout")
.withDescription(
"Timeout used for the lookup of the JobManager.
The timeout value has to contain a time-unit"
+ " specifier (ms/s/min/h/d).");
- /** @deprecated use {@link #LOOKUP_TIMEOUT_DURATION} */
Review Comment:
revert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
