TanYuxin-tyx commented on code in PR #22975:
URL: https://github.com/apache/flink/pull/22975#discussion_r1270396604
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/GateBuffersSpecTest.java:
##########
@@ -143,17 +144,25 @@ void
testCalculationWithConfiguredZeroExclusiveBuffer(ResultPartitionType partit
void testConfiguredMaxRequiredBuffersPerGate(ResultPartitionType
partitionType) {
Optional<Integer> emptyConfig = Optional.empty();
int effectiveMaxRequiredBuffers =
- getEffectiveMaxRequiredBuffersPerGate(partitionType,
emptyConfig);
+ getEffectiveMaxRequiredBuffersPerGate(partitionType,
emptyConfig, false);
int expectEffectiveMaxRequiredBuffers =
isPipelinedOrHybridResultPartition(partitionType)
?
InputGateSpecUtils.DEFAULT_MAX_REQUIRED_BUFFERS_PER_GATE_FOR_STREAM
- :
InputGateSpecUtils.DEFAULT_MAX_REQUIRED_BUFFERS_PER_GATE_FOR_BATCH;
+ : DEFAULT_MAX_REQUIRED_BUFFERS_PER_GATE_FOR_BATCH;
Review Comment:
Why `DEFAULT_MAX_REQUIRED_BUFFERS_PER_GATE_FOR_BATCH` is different with
`InputGateSpecUtils.DEFAULT_MAX_REQUIRED_BUFFERS_PER_GATE_FOR_STREAM`.
We'd better keep the two import formats consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
